• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
1.8.1 crashes
#11
Wow, I'm surprised to hear that you are just getting a black screen. That sounds like some kind of error is happening with processing your files. Is that happening with every file you've tried?

As for the slowdown, I definitely can't explain that one, as I didn't really change any of the code involved with going from the song display back to the library screen. I did make a lot of changes to the chord pro processing in order to support transposing chords in comments and to support having highlight commands combined with other text on the same line. The new code is certainly slower than the old code due to additional processing that is required for each line, but the difference on my tablet seemed minimal.

Mike
Reply
#12
On the good side: I upgraded my backup tablet (Asus Z300M) and everything seems to work fine.

As for the phone, I uploaded a movie that shows what happens.
http://www.squirrel.nl/pub/xfer/uploads/...gW00FA.m4v

Note that all 'lead sheet' songs are ChordPro files, but "Bye Bye Love ptg" is an image (PNG) file.

As for "highlight commands combined with other text on the same line": If you mean "Foo {highlight: bar} blech": This is explicitly not part of the ChordPro standard. For ChordPro 6 (or 5.x) I'm currently considering a subset of markdown.
Johan
http://www.johanvromans.nlhttp://www.howsagoin.nlhttp://www.hetgeluidvanseptember.nl
Samsung Galaxy Note 2 (N8010) 10.1", Android 7.1.2 (LineageOS), AirTurn Duo.
Asus Zenpad (Z300M) 10.1", Android 7.0 (backup tablet).
Samsung A3 (SM-A320FL), Android 7.0 (emergency).
Reply
#13
"Foo {highlight: bar} blech": This is explicitly not part of the ChordPro standard. For ChordPro 6 (or 5.x) I'm currently considering a subset of markdown. 

I hope this is coming soon. I miss it very often.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 1709
http://www.moonlightcrisis.de - http://www.basdjo.de - http://www.frankenbaend.de


Reply
#14
It looks like there is a bug when a highlight command gets cut off due to wrapping. If the entire line is just a highlight command and it gets wrapped, it causes an endless loop in my code. This explains why you only see a black screen (or the previously loaded song), but also the slowdown, because the background thread never terminates and is just eating up the CPU. I think my code eventually kills the thread and cleans up when you switch to a different song that loads correctly though. I'll make sure to get out a fix for this ASAP.

Thanks,
Mike
Reply
#15
I can confirm this is solved in 1.8.4. Good job!
Johan
http://www.johanvromans.nlhttp://www.howsagoin.nlhttp://www.hetgeluidvanseptember.nl
Samsung Galaxy Note 2 (N8010) 10.1", Android 7.1.2 (LineageOS), AirTurn Duo.
Asus Zenpad (Z300M) 10.1", Android 7.0 (backup tablet).
Samsung A3 (SM-A320FL), Android 7.0 (emergency).
Reply


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2018 MyBB Group.