• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Find Missing Files
#11
> As a side note, you should have been able to move the storage location from inside the app without having to go through all those steps...

I could have changed the storage location, that's true. But there were already 1100 songs in the database that were already at my new storage location. I could not avoid that MSP wanted to move the files. So I had to clear the database befor changing the storage location.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 1803
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#12
It would be nice if the current Mobile Sheets Storage Location would be displayed on the settings page as it is the case with the current values of e.g. "Language" or "Page Color Tone"
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 1803
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#13
So possibly these other findings are also caused by this control and are bound to be changed in a following version:
- Expand All, Collapse All don't work
- the Cancel button during detection of missing files doesn't work as expected
- after "Cancel" the missing files so far are not displayed. There's only all or nothing
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 1803
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#14
Expand/Collapse all do appear to work correctly with the new control. I'll have to look into the cancel button issue some more, but for me it takes less than two seconds to find the missing files, so I'm not sure that is a huge deal. Hopefully it will work that quickly for you now as well.

Thanks,
Mike
Reply
#15
Really fast. Thank you.
Expand/collapse works fine now.
Cancel is as before. You're right, that's not an issue anymore when "Find Missing Files" is fast enough.

But: "Find Missing Files" is unusable now, it reports almost all songs as missing.
The songs in MSP are working fine, the report of "Find Missing Files" shows the same path as the song editor where the files really exist.
Very strange: When I click a song in the report it shows an error message (probably from Windows) that refers to a completely different path.
It's an old path that I used a while ago with MSP on Win10, but the PDF that I clicked was never stored there and it was never used as MSP storage folder.
This is a new issue in 1.9.7 and did not happen in 1.9.6
See screen shots.
What I tried so far with no change:
- I used a new mobilesheets.db copied from MSP 1.9.7 on Android
- I applied "Clear Library" before copying mobilesheets.db again
- I deleted all *.db files in the LocalState folder before copying mobilesheets.db again


Attached Files Thumbnail(s)
       
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 1803
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#16
I tried to speed up the missing file detection by first building a dictionary of the paths of every file found in the storage location (and all subdirectories). I then iterate over every song in the library to see if the paths of the files in use by that song are found in that dictionary. I'm not sure why this approach is generating the unusual errors you are seeing. I can go back to the old approach where I just look at each file and check to see if it exists. I just tested this with a library containing around 5500 songs, and the old approach is actually faster (there wasn't a noticeable difference with only about 500 songs). I'll push another update at the end of the week to address this and any other reported bugs.

Thanks,
Mike
Reply
#17
Thanks Mike.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 1803
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#18
"Find Missing Files" is working again in 1.9.9 - thank you Mike.

But some new issues are to be reported:
1. there's no "Fix Broken File Paths" option in the Win10 version as it exists on Android
I'm not sure if I ever used it before on Win10, it would be useful anyway

On the results page of "Find Missing Files" I clicked on one of the missing files and selected a new PDF in a subdirectory of the MSP folder. "Swap Files" opens
2. There's no "Use from the selected path" option. The path of the selected file is fine, I do not want to move or copy it. The handling on Android is completely different, no "Swap Files" window, just selecting the new file.
Maybe "Use from the selected path" has to be greyed for paths outside the MSP folder as that's not possible on Win10.
3. NullReferenceException: I select "Copy new file to same folder as replaced file" - just to see what happens, the original folder /storage/sdcard0 is a remainder from Android (which is definitely strange on Win10). That leads to a NullReferenceException. Not a big problem, "OK" closes the message window and I'm back again without further issues.
4. I select "Copy to MobileSheets folder" instead. "Copied successfully" is reported, the file is copied correctly. But it stays in the list of missing files with the unchanged old path. When I click it again "unknown error" is reported. Restarting MSP as proposed by the error message is not required. "OK" closes the error window and I'm back again. I can close the missing file list and MSP works as usual


Attached Files Thumbnail(s)
           
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 1803
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2018 MyBB Group.