• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
ChordPro directives not recognized without colon
#1
As many ChordPro users I have the habit of using terminating directive keywords with a colon, e.g.

Code:
{title: My Song}

However, the colon has always been optional according to the ChordPro specification.

I can live with MSPro requiring the colon, as it is just nicer/better, but users importing arbitrary ChordPro files from the internet may occasionally get a surprise...
For example, you'll quickly notice that the song title is not picked up, but you'll probably not going to notice that meta data like composer, key, time, tempo is silently ignored.
Johan
http://www.johanvromans.nlhttp://www.howsagoin.nlhttp://www.hetgeluidvanseptember.nl
Samsung Galaxy Note 2 (N8010) 10.1", Android 7.1.2 (LineageOS), AirTurn Duo.
Asus Zenpad (Z300M) 10.1", Android 7.0 (backup tablet).
Samsung A3 (SM-A320FL), Android 7.0 (emergency).
Reply
#2
I didn't know by now that the colons are optional and never came across ChordPro files without them.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 1709
http://www.moonlightcrisis.de - http://www.basdjo.de - http://www.frankenbaend.de


Reply
#3
I was actually handling this correctly for about half of the commands (the ones not related to metadata). I've updated the code to use the same approach in all places so it should work now for all chord pro commands.

Thanks,
Mike
Reply


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2018 MyBB Group.